feat: show location info in parse errors #958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
reviewed
Aug 28, 2023
There was a problem hiding this comment.
Thank you @MartinNowak -- this looks like a nice change to me. If we can get the CI to pass I think we should merge it.
❤️
- add consistent Display for Location - show (optional) token location in parse errors - keep Location line = 0 as noop
- in parse_sql and try_with_sql - update test_parser_error_loc - change test_utils to parse without locations to avoid maintenance overhead BREAKING CHANGE: changes the default ParserError messages
MartinNowak
force-pushed
the
parser-error-loc
branch
from
9054ada
to
cad04da
Compare
Fixed @alamb |
alamb
approved these changes
Sep 7, 2023
There was a problem hiding this comment.
Thanks @MartinNowak -- this looks great to me. Sorry for the delay in review I was away last week
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does not attempt to add locations to the AST (#757).
Hence it's backwards compatible except for changing the default ParserError messages.