New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability for dialects to override prefix, infix, and statement parsing #581
Merged
andygrove
merged 16 commits into
sqlparser-rs:main
from
andygrove:dialect-override-prefix-infix
Aug 19, 2022
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
41c9969
prototype ability for dialects to override prefix and infix parsing
andygrove af39f1f
save progress
andygrove cec3108
it compiles
andygrove eadd846
it works
andygrove b299687
clippy
andygrove 1445886
no-std support
andygrove 3c65284
no-std support
andygrove 28568de
pass Parser instead of tokens
andygrove ab5e683
move a SQLite statement parser
andygrove f70ff47
parse statement directly instead of returning a function
andygrove f7b57fa
parse prefix and infix directly instead of returning a function
andygrove 9dd2ea4
revert no-std fix
andygrove c2e096e
revert no-std fix
andygrove f518c30
unit test for custom infix parser
andygrove 8640d1b
more tests
andygrove ed14940
move tests
andygrove File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,138 @@ | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
//! Test the ability for dialects to override parsing | ||
|
||
use sqlparser::{ | ||
ast::{BinaryOperator, Expr, Statement, Value}, | ||
dialect::Dialect, | ||
keywords::Keyword, | ||
parser::{Parser, ParserError}, | ||
tokenizer::Token, | ||
}; | ||
|
||
#[test] | ||
fn custom_prefix_parser() -> Result<(), ParserError> { | ||
#[derive(Debug)] | ||
struct MyDialect {} | ||
|
||
impl Dialect for MyDialect { | ||
fn is_identifier_start(&self, ch: char) -> bool { | ||
is_identifier_start(ch) | ||
} | ||
|
||
fn is_identifier_part(&self, ch: char) -> bool { | ||
is_identifier_part(ch) | ||
} | ||
|
||
fn parse_prefix(&self, parser: &mut Parser) -> Option<Result<Expr, ParserError>> { | ||
if parser.consume_token(&Token::Number("1".to_string(), false)) { | ||
Some(Ok(Expr::Value(Value::Null))) | ||
} else { | ||
None | ||
} | ||
} | ||
} | ||
|
||
let dialect = MyDialect {}; | ||
let sql = "SELECT 1 + 2"; | ||
let ast = Parser::parse_sql(&dialect, sql)?; | ||
let query = &ast[0]; | ||
assert_eq!("SELECT NULL + 2", &format!("{}", query)); | ||
Ok(()) | ||
} | ||
|
||
#[test] | ||
fn custom_infix_parser() -> Result<(), ParserError> { | ||
#[derive(Debug)] | ||
struct MyDialect {} | ||
|
||
impl Dialect for MyDialect { | ||
fn is_identifier_start(&self, ch: char) -> bool { | ||
is_identifier_start(ch) | ||
} | ||
|
||
fn is_identifier_part(&self, ch: char) -> bool { | ||
is_identifier_part(ch) | ||
} | ||
|
||
fn parse_infix( | ||
&self, | ||
parser: &mut Parser, | ||
expr: &Expr, | ||
_precendence: u8, | ||
) -> Option<Result<Expr, ParserError>> { | ||
if parser.consume_token(&Token::Plus) { | ||
Some(Ok(Expr::BinaryOp { | ||
left: Box::new(expr.clone()), | ||
op: BinaryOperator::Multiply, // translate Plus to Multiply | ||
right: Box::new(parser.parse_expr().unwrap()), | ||
})) | ||
} else { | ||
None | ||
} | ||
} | ||
} | ||
|
||
let dialect = MyDialect {}; | ||
let sql = "SELECT 1 + 2"; | ||
let ast = Parser::parse_sql(&dialect, sql)?; | ||
let query = &ast[0]; | ||
assert_eq!("SELECT 1 * 2", &format!("{}", query)); | ||
Ok(()) | ||
} | ||
|
||
#[test] | ||
fn custom_statement_parser() -> Result<(), ParserError> { | ||
#[derive(Debug)] | ||
struct MyDialect {} | ||
|
||
impl Dialect for MyDialect { | ||
fn is_identifier_start(&self, ch: char) -> bool { | ||
is_identifier_start(ch) | ||
} | ||
|
||
fn is_identifier_part(&self, ch: char) -> bool { | ||
is_identifier_part(ch) | ||
} | ||
|
||
fn parse_statement(&self, parser: &mut Parser) -> Option<Result<Statement, ParserError>> { | ||
if parser.parse_keyword(Keyword::SELECT) { | ||
for _ in 0..3 { | ||
let _ = parser.next_token(); | ||
} | ||
Some(Ok(Statement::Commit { chain: false })) | ||
} else { | ||
None | ||
} | ||
} | ||
} | ||
|
||
let dialect = MyDialect {}; | ||
let sql = "SELECT 1 + 2"; | ||
let ast = Parser::parse_sql(&dialect, sql)?; | ||
let query = &ast[0]; | ||
assert_eq!("COMMIT", &format!("{}", query)); | ||
Ok(()) | ||
} | ||
|
||
fn is_identifier_start(ch: char) -> bool { | ||
('a'..='z').contains(&ch) || ('A'..='Z').contains(&ch) || ch == '_' | ||
} | ||
|
||
fn is_identifier_part(ch: char) -> bool { | ||
('a'..='z').contains(&ch) | ||
|| ('A'..='Z').contains(&ch) | ||
|| ('0'..='9').contains(&ch) | ||
|| ch == '$' | ||
|| ch == '_' | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This dialect-specific code has now moved to the appropriate dialects.