Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disambiguate CREATE ROLE ... USER and GROUP #628

Merged
merged 1 commit into from Sep 27, 2022

Conversation

alamb
Copy link
Collaborator

@alamb alamb commented Sep 27, 2022

Rather than assume ROLE and USER are synonyms in the parser, let's parse them separately and allow upstream crates to treat them the same if they desire

Per comment https://github.com/sqlparser-rs/sqlparser-rs/pull/598/files#r981277941 on contribution from @blx

@alamb
Copy link
Collaborator Author

alamb commented Sep 27, 2022

cc @blx

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3136427473

  • 27 of 40 (67.5%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 85.501%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tests/sqlparser_postgres.rs 11 12 91.67%
src/ast/mod.rs 4 6 66.67%
src/parser.rs 12 22 54.55%
Totals Coverage Status
Change from base Build 3136407158: -0.05%
Covered Lines: 10102
Relevant Lines: 11815

💛 - Coveralls

Copy link
Contributor

@blx blx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems more sensible and flexible 👍

@alamb alamb merged commit 6afd194 into sqlparser-rs:main Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants