Fix parsing of COLLATE after parentheses in expressions (#507)

sqlparser-rs · May 25, 2022 · 0fa812b · 0fa812b
1 parent 901f5b9
commit 0fa812b
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 10 deletions.
diff --git a/src/parser.rs b/src/parser.rs
@@ -525,17 +525,18 @@ impl<'a> Parser<'a> {
                     };
                 self.expect_token(&Token::RParen)?;
                 if !self.consume_token(&Token::Period) {
-                    return Ok(expr);
+                    Ok(expr)
+                } else {
+                    let tok = self.next_token();
+                    let key = match tok {
+                        Token::Word(word) => word.to_ident(),
+                        _ => return parser_err!(format!("Expected identifier, found: {}", tok)),
+                    };
+                    Ok(Expr::CompositeAccess {
+                        expr: Box::new(expr),
+                        key,
+                    })
                 }
-                let tok = self.next_token();
-                let key = match tok {
-                    Token::Word(word) => word.to_ident(),
-                    _ => return parser_err!(format!("Expected identifier, found: {}", tok)),
-                };
-                Ok(Expr::CompositeAccess {
-                    expr: Box::new(expr),
-                    key,
-                })
             }
             Token::Placeholder(_) => {
                 self.prev_token();

diff --git a/tests/sqlparser_common.rs b/tests/sqlparser_common.rs
@@ -561,6 +561,15 @@ fn parse_collate() {
     );
 }
 
+#[test]
+fn parse_collate_after_parens() {
+    let sql = "SELECT (name) COLLATE \"de_DE\" FROM customer";
+    assert_matches!(
+        only(&all_dialects().verified_only_select(sql).projection),
+        SelectItem::UnnamedExpr(Expr::Collate { .. })
+    );
+}
+
 #[test]
 fn parse_select_string_predicate() {
     let sql = "SELECT id, fname, lname FROM customer \