Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix passenv to work with tox 4 #4154

Merged
merged 1 commit into from
Dec 12, 2022
Merged

Conversation

tunetheweb
Copy link
Member

@tunetheweb tunetheweb commented Dec 12, 2022

Brief summary of the change made

tox4 changes passenv to a comma-separated list, rather than space-separated: tox-dev/tox#2658

Are there any other side effects of this change that we should be aware of?

This is only really important for CI (which uses latest tox), so think it should be OK even for v3 users.

I also removed the last remaining references to CIRCLECI that we replaced with GitHub Actions a long time ago.

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (dc39e38) compared to base (9cd847e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #4154   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          195       195           
  Lines        14920     14920           
=========================================
  Hits         14920     14920           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tunetheweb tunetheweb merged commit dc59c2a into sqlfluff:main Dec 12, 2022
@tunetheweb tunetheweb deleted the fix-pass-env branch December 12, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants