Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dolphin: Fix the return type of SUM() #3223

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Jille
Copy link
Contributor

@Jille Jille commented Feb 26, 2024

No description provided.

@kyleconroy
Copy link
Collaborator

Is this accurate? In PostgreSQL, SUM is polymorphic and returns the type of its input parameters.

@Jille
Copy link
Contributor Author

Jille commented Mar 24, 2024

Good point. I'll write it out for all types, just like the PostgreSQL catalog does.

However, picking the right function from the catalog doesn't seem to work yet (https://play.sqlc.dev/p/a09737c4aa272d364f56e1a9b5d24d1424a5cc6b5b29ad8da220990129db6c92).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants