Fix/nullable joins #1486
Closed
Fix/nullable joins #1486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The lack of this field creates an issue for queries using wildcard for select. When comparing `*n.Alias.Aliasname == col.TableAlias` isTableRequired would always return not found
sbres
force-pushed
the
fix/nullable-joins
branch
from
bbea21a
to
c6e5297
Compare
This where breaking before, like this there is am example for make test-endtoend to detect
|
Depends on #1488 for test to run properly |
kyleconroy
requested changes
Mar 19, 2022
Comment on lines
-19
to
-22
| if n, ok := item.(*ast.String); ok { | ||
| items = append(items, n.Str) | ||
| continue | ||
| } |
There was a problem hiding this comment.
Can you explain why this needs to be removed?
There was a problem hiding this comment.
If you look at the full function the condition is there twice.
I was tidying a little bit the code, it does not impact anything.
func stringSlice(list *ast.List) []string {
items := []string{}
for _, item := range list.Items {
if n, ok := item.(*ast.String); ok {
items = append(items, n.Str)
continue
}
if n, ok := item.(*ast.String); ok {
items = append(items, n.Str)
continue
}
|
Maybe we should just close this PR as #1491 already fixes the same thing and was merged right away |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix #1334 and #1349
Columns with star reference were lacking the TableAlias attribute. Now it's set to t.Rel.Name like in expand()