Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove data_type from column proto #1468

Merged
merged 1 commit into from Mar 2, 2022
Merged

Remove data_type from column proto #1468

merged 1 commit into from Mar 2, 2022

Commits on Mar 2, 2022

  1. fix bug where datatype is read from 

    See sqlc-dev#1460 (comment)

DataType is never filled in so this comparison is buggy. This change mirrors
what the go gen.go does instead.

Deleting a field from proto can be not safe for compat, so we could use
https://developers.google.com/protocol-buffers/docs/proto3#reserved,
but I think these protos are transient so it should be ok.
    @stephen
    stephen committed Mar 2, 2022
    Copy the full SHA
    2cec58a View commit details
    Browse the repository at this point in the history