Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQLite: Adds a few more tests, fixes DROP TABLE #1443

Merged
merged 13 commits into from Feb 18, 2022

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

@@ -0,0 +1,2 @@
/* name: Placeholder :many */
SELECT * from venues;
@@ -0,0 +1,3 @@
CREATE TABLE venues (name text);
ALTER TABLE venues ADD location text;
ALTER TABLE venues ADD COLUMN size integer;
@@ -0,0 +1,12 @@
{
"version": "1",
"packages": [
{
"path": "go",
"engine": "_lemon",
"name": "querytest",
"schema": "schema.sql",
"queries": "query.sql"
}
]
}

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

@@ -1,2 +1,2 @@
-- name: Placeholder :exec
SELECT 1;
SELECT * from foo;
29 changes: 29 additions & 0 deletions internal/endtoend/testdata/ddl_alter_table_rename/sqlite/go/db.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

@@ -0,0 +1,2 @@
/* name: Placeholder :many */
SELECT * from arenas;
@@ -0,0 +1,3 @@
CREATE TABLE venues (name text);
ALTER TABLE venues RENAME TO arenas;

12 changes: 12 additions & 0 deletions internal/endtoend/testdata/ddl_alter_table_rename/sqlite/sqlc.json
@@ -0,0 +1,12 @@
{
"version": "1",
"packages": [
{
"path": "go",
"engine": "_lemon",
"name": "querytest",
"schema": "schema.sql",
"queries": "query.sql"
}
]
}

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

@@ -0,0 +1,2 @@
/* name: Placeholder :many */
SELECT * from foo;
@@ -0,0 +1,4 @@
CREATE TABLE foo (bar text);
ALTER TABLE foo RENAME COLUMN bar TO baz;

ALTER TABLE foo RENAME baz TO boo;
@@ -0,0 +1,12 @@
{
"version": "1",
"packages": [
{
"path": "go",
"engine": "_lemon",
"name": "querytest",
"schema": "schema.sql",
"queries": "query.sql"
}
]
}

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions internal/endtoend/testdata/ddl_create_table/sqlite/schema.sql
@@ -1 +1,3 @@
CREATE TABLE venues (name text);

CREATE TABLE IF NOT EXISTS arenas (name text PRIMARY KEY, location text, size int NOT NULL) WITHOUT ROWID;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we create a separate test for create table without rowID? I don't think it applies to any other engine than SQLite

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do, I was mostly trying to exercise the parser and make sure it didn't complain, I don't think these extra options have any impact on anything that sqlc cares about.

29 changes: 29 additions & 0 deletions internal/endtoend/testdata/ddl_create_trigger/sqlite/go/db.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 13 additions & 0 deletions internal/endtoend/testdata/ddl_create_trigger/sqlite/go/models.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

@@ -0,0 +1,2 @@
-- name: Placeholder :exec
SELECT 1;