fix(compiler): Fix left join nullability with table aliases (#1491)

sqlc-dev · Mar 16, 2022 · 916b8d3 · 916b8d3
1 parent 9240b66
commit 916b8d3
Show file tree

Hide file tree

Showing 7 changed files with 954 additions and 9 deletions.
diff --git a/internal/compiler/output_columns.go b/internal/compiler/output_columns.go
@@ -182,14 +182,15 @@ func outputColumns(qc *QueryCatalog, node ast.Node) ([]*Column, error) {
 							cname = *res.Name
 						}
 						cols = append(cols, &Column{
-							Name:     cname,
-							Type:     c.Type,
-							Scope:    scope,
-							Table:    c.Table,
-							DataType: c.DataType,
-							NotNull:  c.NotNull,
-							IsArray:  c.IsArray,
-							Length:   c.Length,
+							Name:       cname,
+							Type:       c.Type,
+							Scope:      scope,
+							Table:      c.Table,
+							TableAlias: t.Rel.Name,
+							DataType:   c.DataType,
+							NotNull:    c.NotNull,
+							IsArray:    c.IsArray,
+							Length:     c.Length,
 						})
 					}
 				}

diff --git a/internal/endtoend/testdata/join_left/mysql/go/models.go b/internal/endtoend/testdata/join_left/mysql/go/models.go