Skip to content

Commit

Permalink
fix(sqlite): Fix DROP TABLE (#1443)
Browse files Browse the repository at this point in the history
* Improve test to illustrate correctness
* Add tests for:
  * Renaming tables
  * Renaming columns
  * Renaming columns without COLUMN keyword
  * Adding a column
  * Creating a trigger
  * Dropping a table if exists
  • Loading branch information
PadraigK committed Feb 18, 2022
1 parent 5c5ae9b commit 557dff6
Show file tree
Hide file tree
Showing 41 changed files with 523 additions and 9 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

@@ -0,0 +1,2 @@
/* name: Placeholder :many */
SELECT * from venues;
@@ -0,0 +1,3 @@
CREATE TABLE venues (name text);
ALTER TABLE venues ADD location text;
ALTER TABLE venues ADD COLUMN size integer;
@@ -0,0 +1,12 @@
{
"version": "1",
"packages": [
{
"path": "go",
"engine": "_lemon",
"name": "querytest",
"schema": "schema.sql",
"queries": "query.sql"
}
]
}

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

@@ -1,2 +1,2 @@
-- name: Placeholder :exec
SELECT 1;
SELECT * from foo;
29 changes: 29 additions & 0 deletions internal/endtoend/testdata/ddl_alter_table_rename/sqlite/go/db.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

@@ -0,0 +1,2 @@
/* name: Placeholder :many */
SELECT * from arenas;
@@ -0,0 +1,3 @@
CREATE TABLE venues (name text);
ALTER TABLE venues RENAME TO arenas;

12 changes: 12 additions & 0 deletions internal/endtoend/testdata/ddl_alter_table_rename/sqlite/sqlc.json
@@ -0,0 +1,12 @@
{
"version": "1",
"packages": [
{
"path": "go",
"engine": "_lemon",
"name": "querytest",
"schema": "schema.sql",
"queries": "query.sql"
}
]
}

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

@@ -0,0 +1,2 @@
/* name: Placeholder :many */
SELECT * from foo;
@@ -0,0 +1,4 @@
CREATE TABLE foo (bar text);
ALTER TABLE foo RENAME COLUMN bar TO baz;

ALTER TABLE foo RENAME baz TO boo;
@@ -0,0 +1,12 @@
{
"version": "1",
"packages": [
{
"path": "go",
"engine": "_lemon",
"name": "querytest",
"schema": "schema.sql",
"queries": "query.sql"
}
]
}

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions internal/endtoend/testdata/ddl_create_table/sqlite/schema.sql
@@ -1 +1,3 @@
CREATE TABLE venues (name text);

CREATE TABLE IF NOT EXISTS arenas (name text PRIMARY KEY, location text, size int NOT NULL) WITHOUT ROWID;
29 changes: 29 additions & 0 deletions internal/endtoend/testdata/ddl_create_trigger/sqlite/go/db.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 13 additions & 0 deletions internal/endtoend/testdata/ddl_create_trigger/sqlite/go/models.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

@@ -0,0 +1,2 @@
-- name: Placeholder :exec
SELECT 1;

0 comments on commit 557dff6

Please sign in to comment.