Skip to content

Commit

Permalink
typo fixes
Browse files Browse the repository at this point in the history
Change-Id: I8f3a1d755d03e6c11fa1f783f111977b7ddc22fb
(cherry picked from commit 96a50e3)
  • Loading branch information
zzzeek committed May 5, 2024
1 parent 79474c3 commit de3dd73
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 13 deletions.
11 changes: 5 additions & 6 deletions doc/build/changelog/unreleased_20/11200.rst
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,8 @@
:tags: bug, typing, regression
:tickets: 11200

Fixed typing regression caused by PR :ticket:`11055` in version 2.0.29 that
attempted to add ``ParamSpec`` to the asyncio ``run_sync()`` methods, where
using :meth:`_asyncio.AsyncConnection.run_sync` with
:meth:`_schema.MetaData.reflect` would fail on mypy due to a bug.
See https://github.com/python/mypy/issues/17093 for details.
Pull request courtesy of Francisco R. Del Roio
Fixed typing regression caused by :ticket:`11055` in version 2.0.29 that
added ``ParamSpec`` to the asyncio ``run_sync()`` methods, where using
:meth:`_asyncio.AsyncConnection.run_sync` with
:meth:`_schema.MetaData.reflect` would fail on mypy due to a mypy issue.
Pull request courtesy of Francisco R. Del Roio.
4 changes: 2 additions & 2 deletions doc/build/changelog/unreleased_20/11220.rst
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
:tags: bug, orm
:tickets: 11220

Added new attribute :attr:`_orm.ORMExecuteState.is_from_statement`, to
detect statements of the form ``select().from_statement()``, and also
Added new attribute :attr:`_orm.ORMExecuteState.is_from_statement` to
detect statements created using :meth:`_sql.Select.from_statement`, and
enhanced ``FromStatement`` to set :attr:`_orm.ORMExecuteState.is_select`,
:attr:`_orm.ORMExecuteState.is_insert`,
:attr:`_orm.ORMExecuteState.is_update`, and
Expand Down
2 changes: 1 addition & 1 deletion doc/build/changelog/unreleased_20/11291.rst
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
:tags: bug, orm
:tickets: 11291

Fixed issue in :func:`_orm.selectin_polymorhpic` loader option where
Fixed issue in :func:`_orm.selectin_polymorphic` loader option where
attributes defined with :func:`_orm.composite` on a superclass would cause
an internal exception on load.

2 changes: 1 addition & 1 deletion doc/build/changelog/unreleased_20/11327.rst
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
:tags: bug, orm
:tickets: 11327

Fixed issue in :func:`_orm.selectin_polymorhpic` loader option where the
Fixed issue in :func:`_orm.selectin_polymorphic` loader option where the
SELECT emitted would only accommodate for the child-most class among the
result rows that were returned, leading intermediary-class attributes to be
unloaded if there were no concrete instances of that intermediary-class
Expand Down
7 changes: 4 additions & 3 deletions doc/build/changelog/unreleased_20/11332.rst
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
:tags: bug, orm
:tickets: 11332

Fixes issue in :meth:`_orm.Session.bulk_save_objects` where it would write a
wrong identity key when using ``return_defaults=True``.
The wrong identity key could lead to an index error when entities are then pickled.
Fixed issue in :meth:`_orm.Session.bulk_save_objects` where the form of the
identity key produced when using ``return_defaults=True`` would be
incorrect. This could lead to an errors during pickling as well as identity
map mismatches.

0 comments on commit de3dd73

Please sign in to comment.