Ignore newlines in expressions for Computed

[GeorchW]

Fixes #1391

There's already a function that normalizes expressions from generated columns and server defaults. It looks like this:

def _normalize_computed_default(sqltext: str) -> str:
    """we want to warn if a computed sql expression has changed.  however
    we don't want false positives and the warning is not that critical.
    so filter out most forms of variability from the SQL text.

    """

    return re.sub(r"[ \(\)'\"`\[\]]", "", sqltext).lower()

I added the characters \r\n\t to the ones that are removed.

Description

I added the characters \r\n\t to the regex that normalizes the expressions, that's it. Also added a test case.

Checklist

This pull request is:

• A documentation / typographical error fix
  • Good to go, no issue or tests are needed
• A short code fix
  • please include the issue number, and create an issue if none exists, which
    must include a complete example of the issue. one line code fixes without an
    issue and demonstration will not be accepted.
  • Please include: Fixes: #<issue number> in the commit message
  • please include tests. one line code fixes without tests will not be accepted.
• A new feature implementation
  • please include the issue number, and create an issue if none exists, which must
    include a complete example of how the feature would look.
  • Please include: Fixes: #<issue number> in the commit message
  • please include tests.

Have a nice day!

[CaselIT]

thanks, that change looks good.

I'll add a changelog in gerrit and after review it should be merged. Thanks!

[sqla-tester]

OK, this is sqla-tester setting up my work on behalf of CaselIT to try to get revision 6995924 of this pull request into gerrit so we can run tests and reviews and stuff

[sqla-tester]

New Gerrit review created for change 6995924: https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5105

[sqla-tester]

Michael Bayer (zzzeek) wrote:

thank you!

View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5105

[sqla-tester]

Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5105 has been merged. Congratulations! :)