Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share code between ToolTip and CallTip #17902

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

maurerle
Copy link
Contributor

Description of Changes

  • this creates a base class for ToolTip and CallTip as they are indeed quite similar
  • this should be refactoring only without logic changes
  • I did not change the behavior intendently, I changed the ordering in the initialization but otherwise this should not change the behaviour.

One could probably go even further, but I think its a good compromise to deduplicate the code without changing a lot

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

Issue(s) Resolved

Fixes #9339

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: Florian Maurer

@pep8speaks
Copy link

pep8speaks commented May 17, 2022

Hello @maurerle! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2023-11-28 11:55:22 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify calltip and tooltip widget
2 participants