PR: Update Jedi requirement to 0.17 and Parso to 0.7 #12792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
goanpeca
previously requested changes
May 19, 2020
There was a problem hiding this comment.
Hi @andfoy thanks for working on this!
To avoid pep8speaks messages on external libraries we are bundling with Spyder (dafsa.py), could you please update the (pep8speaks.yml](https://github.com/spyder-ide/spyder/blob/master/.pep8speaks.yml) to exclude those directories?
I think something like this should work.
On the test failures, it seems conda is finding conflicts trying to resolve the environment
You will probably need to run the install.sh script locally to debug the dependencies that need to be updated to prevent the conflicts.
external-deps/python-language-server/ subrepo: subdir: "external-deps/python-language-server" merged: "9b5cb2197" upstream: origin: "https://github.com/palantir/python-language-server.git" branch: "develop" commit: "9b5cb2197" git-subrepo: version: "0.4.1" origin: "https://github.com/ingydotnet/git-subrepo" commit: "a04d8c2"
ccordoba12
changed the title
ccordoba12
approved these changes
Jun 5, 2020
There was a problem hiding this comment.
Thanks a lot for this @andfoy! At the end I decided to disable the Python 2 slow slots from our GH actions to be able to merge this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This PR enables support for the latest Jedi version, v0.1.7
Issue(s) Resolved
Fixes #12572
Fixes #12333
Fixes #11933
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: @andfoy