Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add freezegun to ignore list to avoid infinite recursion in TickingDa… #273

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sanvyruz
Copy link

  • Adding "freezegun" into list of ignore packages, to avoid infinite recursion inside TickingDateTimeFactory

@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 92.353% when pulling f764302 on sanvyruz:master into a4620f6 on spulec:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 92.353% when pulling f764302 on sanvyruz:master into a4620f6 on spulec:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 92.353% when pulling f764302 on sanvyruz:master into a4620f6 on spulec:master.

@coveralls
Copy link

coveralls commented Oct 23, 2018

Coverage Status

Coverage increased (+0.2%) to 92.095% when pulling 8773c90 on sanvyruz:master into a4620f6 on spulec:master.

@boxed
Copy link
Contributor

boxed commented Oct 23, 2018

We should definitely do this, but shouldn't the change just be to add to the default ignore list at https://github.com/spulec/freezegun/blob/master/freezegun/api.py#L718 ?

@sanvyruz
Copy link
Author

@boxed I did that initially, but then _should_use_real_time returns a True even within the tests causing them to fail. So added it back to default ignore list conditionally when tick=True (which probably works because there is no test with such condition?)

Perhaps a better way would be to able to add "freezegun.api" to ignore list except in testing environment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants