Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove coveralls #9

Merged
merged 1 commit into from Oct 18, 2018
Merged

Remove coveralls #9

merged 1 commit into from Oct 18, 2018

Conversation

alexkilgour
Copy link
Contributor

@alexkilgour alexkilgour commented Oct 18, 2018 •
edited

Had to remove coveralls as it is misreporting our coverage due to an issue with Jest when you rewire functions

jhnns/rewire#145

o-t-w
o-t-w approved these changes Oct 18, 2018
View reviewed changes
Copy link
Contributor

@o-t-w o-t-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alexkilgour alexkilgour merged commit 2b58829 into master Oct 18, 2018
@alexkilgour alexkilgour deleted the remove-coveralls branch October 18, 2018 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@o-t-w o-t-w o-t-w approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexkilgour @o-t-w