Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a way to disable/control cleanup cron #1160

Closed

Conversation

saiya
Copy link

@saiya saiya commented Aug 18, 2018

Provide following features on Redis and JDBC backend (discussed in #1159).

  • Way to stop cleanup cron (set cleanupCron = "disabled")
  • Enable to use property placeholder within cleanupCron attribute

This resolves #1159.

@pivotal-issuemaster
Copy link

@saiya Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@saiya Thank you for signing the Contributor License Agreement!

@saiya saiya force-pushed the feature/stoppable_cleanup_cron branch from 97503fb to fb0251d Compare August 18, 2018 05:06
@vpavic vpavic self-assigned this Aug 18, 2018
@vpavic vpavic added this to the 2.1.0.M3 milestone Aug 18, 2018
@saiya
Copy link
Author

saiya commented Aug 23, 2018

Thank you for taking this issue @vpavic .

If there anything I can/should do for this PR, please tell me 👍

@vpavic vpavic modified the milestones: 2.1.0.M3, 2.1.0.RC1 Sep 10, 2018
@vpavic vpavic modified the milestones: 2.1.0.RC1, General Backlog Sep 21, 2018
@vpavic vpavic modified the milestones: General Backlog, 2.2.x Nov 2, 2018
@vpavic vpavic self-requested a review November 2, 2018 11:25
@rwinch rwinch removed the Data Store label May 22, 2019
@vpavic vpavic modified the milestones: 2.2.x, 2.2.0.RC1 Aug 24, 2019
@vpavic
Copy link
Contributor

vpavic commented Sep 3, 2019

Thanks for the PR @saiya, however we'd like to reuse Spring Framework's Scheduled#CRON_DISABLED as a special value to disable session cleanup scheduled job.

Looks like that's going to require some changes in the Framework - see spring-projects/spring-framework#23568.

@vpavic vpavic closed this Sep 3, 2019
@vpavic vpavic removed this from the 2.2.0.RC1 milestone Sep 3, 2019
@vpavic
Copy link
Contributor

vpavic commented Sep 12, 2019

With spring-projects/spring-framework#23568 resolved, starting Spring Session 2.2.0.RC1 it should be possible to disable the cleanup job using Scheduled#CRON_DISABLED for cron value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a way to disable cleanup cron
4 participants