Update @MessageMapping to match input/output cardinality #7669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwinch
added
in: rsocket
type: bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the tests failures when using spring version
5.2.2.BUILD-SNAPSHOT.This Spring Framework issue,
After the commit that fixes the above issue, the test
retrieveFluxWhenDataStringAndPublicThenGrantedis invalid because the destination"retrieve-flux"does not supportREQUEST_STREAM, and only supportREQUEST_CHANNEL, since the input cardinality is 2.Additionally, the destination
"send"was not being used in the testsendWhenPublicThenGrantedbecause it the provided input of cardinality 1 did not match the expectFluxinput of cardinality 2.