Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

instanceof changed to recent syntax #15033

Closed
wants to merge 0 commits into from
Closed

instanceof changed to recent syntax #15033

wants to merge 0 commits into from

Conversation

dukbong
Copy link
Contributor

@dukbong dukbong commented May 9, 2024

instanceof changed to recent syntax

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 9, 2024
marcusdacoregio
marcusdacoregio requested changes May 13, 2024
View reviewed changes
Copy link
Contributor

@marcusdacoregio marcusdacoregio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dukbong, I've left a feedback inline.

core/src/main/java/org/springframework/security/authentication/AbstractAuthenticationToken.java Outdated Show resolved Hide resolved
@marcusdacoregio marcusdacoregio self-assigned this May 13, 2024
@marcusdacoregio marcusdacoregio removed the status: waiting-for-triage An issue we've not yet triaged label May 13, 2024
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 13, 2024
@dukbong
Copy link
Contributor Author

dukbong commented May 13, 2024

Thanks @dukbong, I've left a feedback inline.

Hi! @marcusdacoregio
Thank you for your feedback. I have made the revisions as you suggested.

@marcusdacoregio
Copy link
Contributor

In preparation to merge, can you please squash your commits?

The single commit message could be: Use instanceof Pattern Matching

@marcusdacoregio marcusdacoregio removed status: waiting-for-triage An issue we've not yet triaged labels May 14, 2024
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 14, 2024
@dukbong dukbong force-pushed the Grammar branch 3 times, most recently from 44eae33 to 71da63a Compare May 14, 2024 16:57
@dukbong dukbong closed this May 14, 2024
@dukbong
Copy link
Contributor Author

dukbong commented May 14, 2024

In preparation to merge, can you please squash your commits?

The single commit message could be: Use instanceof Pattern Matching

I'm sorry. @marcusdacoregio

My mistake caused the PR to be removed.

I will submit a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcusdacoregio marcusdacoregio marcusdacoregio requested changes

Assignees

@marcusdacoregio marcusdacoregio

Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dukbong @marcusdacoregio @spring-projects-issues