Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified to set ServerSecurityContextRepository of ServerHttpSecurity #15013

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

earlgrey02
Copy link

@earlgrey02 earlgrey02 commented May 6, 2024

Summary

Added securityContextRepository field variable to set ServerSecurityContextRepository in ServerHttpSecurityDsl.

Description

There is no way in ServerHttpSecurityDsl to set the ServerSecurityContextRepository of ServerHttpSecurity. So I added a field variable to set ServerSecurityContextRepository.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 6, 2024
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @earlgrey02, thanks for the PR!

Will you please do the following three items for me:

  • Add test(s) to confirm the functionality works
  • Change copyright dates so they are updated to the current year
  • Update the commit message to be brief and in the imperative, like
Add SecurityContextRepository to Kotlin Reactive DSL

@jzheaux jzheaux added in: config An issue in spring-security-config type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels May 21, 2024
@earlgrey02 earlgrey02 force-pushed the set-security-context-repository branch from 0c0df51 to 4df815e Compare May 22, 2024 05:36
@earlgrey02
Copy link
Author

Hi, @earlgrey02, thanks for the PR!

Will you please do the following three items for me:

  • Add test(s) to confirm the functionality works
  • Change copyright dates so they are updated to the current year
  • Update the commit message to be brief and in the imperative, like
Add SecurityContextRepository to Kotlin Reactive DSL

Yes, the work has been done.

@jzheaux jzheaux self-assigned this May 23, 2024
@jzheaux jzheaux added this to the 6.4.0-M1 milestone May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: config An issue in spring-security-config type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants