Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved error message for PasswordEncoder #14968

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bottlerocketjonny
Copy link

I fear I might have been too slow to submit this! However, this closes gh-14880

Happy to make any changes.

Signed-off-by: Jonny Coddington <bottlerocketjonny@protonmail.com>
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 26, 2024
@jzheaux
Copy link
Contributor

jzheaux commented Apr 26, 2024

Hi, @bottlerocketjonny! Yes, we already received another PR for the same and I think it is a nice improvement. That said, if you'd like, please rebase once that is merged and push any other changes you'd like to see to this PR, and we can take a look together.

@bottlerocketjonny
Copy link
Author

Hi, @bottlerocketjonny! Yes, we already received another PR for the same and I think it is a nice improvement. That said, if you'd like, please rebase once that is merged and push any other changes you'd like to see to this PR, and we can take a look together.

No worries! Yeah sure thing I shall do that 👍🏻

Just for future reference, if I wanted to work on an issue should I wait to be assigned or just go for it? I left a comment on this one but wasn't sure if that was the way to go. Cheers 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InMemoryUserDetailsManager: consider improving the error message when no PasswordEncoding has been specified
3 participants