Support SpEL Returning AuthorizationDecision #14840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcusdacoregio
requested changes
Apr 4, 2024
core/src/main/java/org/springframework/security/access/expression/ExpressionUtils.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/springframework/security/authorization/method/ReactiveExpressionUtils.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/springframework/security/access/expression/ExpressionUtils.java
Show resolved
Hide resolved
marcusdacoregio
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gh-14599
WIth this PR, an application can return an
AuthorizationDecisionfrom a SpEL expression.Note that the
MethodAuthorizationDeniedHandlerandMethodAuthorizationResultPostProcessorobject hierarchies were modified to ensure that any custom type that is returned from a SpEL expression is preserved. No authorization decision wrapping is performed any longer in this case.This is also valuable for being able to use custom handling and post-processing in the event that the expression throws an exception.