Add ContinueRequestSessionInformationExpiredStrategy #14765
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
| @@ -0,0 +1,35 @@ | |||
| /* | |||
| * Copyright 2002-2016 the original author or authors. | |||
There was a problem hiding this comment.
Can you make sure that the copyright notice includes the current year?
| * A {@link SessionInformationExpiredStrategy} continues to execute subsequent filters | ||
| * even after session expiration. | ||
| * | ||
| * @author Rosie Yang |
There was a problem hiding this comment.
Please add @since 6.3 too
There was a problem hiding this comment.
Thanks! I changed too. I realized I need to pay more attention to contribution rules, sorry about that.
| /** | ||
| * Creates a new instance | ||
| * @param sessionInformation the SessionInformation that is expired | ||
| * @param request the HttpServletRequest | ||
| * @param response the HttpServletResponse | ||
| */ | ||
| public SessionInformationExpiredEvent(SessionInformation sessionInformation, HttpServletRequest request, | ||
| HttpServletResponse response) { | ||
| HttpServletResponse response, FilterChain filterChain) { |
There was a problem hiding this comment.
Instead of changing this constructor, a new constructor should be created accepting all those parameter + the FilterChain. The reason is because if we change this constructor it will be a breaking change for anyone that is using SessionInformationExpiredEvent.
There was a problem hiding this comment.
As you mentioned, I add new constructor below original constructor. But filterChain value need for new constructor i had to handle this in original constructor too.
marcusdacoregio
removed
the
status: waiting-for-triage
spring-projects-issues
added
the
status: waiting-for-triage
- continues to execute subsequent filters even after session expiration. - Issue spring-projects#14077
Description
This PR adds a ContinueRequestSessionInformationExpiredStrategy to contiue next filters even though the session expired.
Changes
Issue #14077