Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link in the In-Memory Authentication documentation #14689

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lukasdo
Copy link

@lukasdo lukasdo commented Mar 5, 2024

For details see #14688

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 5, 2024
@marcusdacoregio
Copy link
Contributor

Hi, @lukasdo. Can you please squash your commits in preparation for merge?

@marcusdacoregio marcusdacoregio self-assigned this Mar 6, 2024
@marcusdacoregio marcusdacoregio added in: docs An issue in Documentation or samples type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 6, 2024
…assword link

spring-projectsGH-14688 Use inter-document xref to fix username and password link
@marcusdacoregio
Copy link
Contributor

@lukasdo, are you sure that the link you changed redirect to a page? I tested on my side and it returned Page Not Found. I believe that the link should redirect to https://docs.spring.io/spring-security/reference/servlet/authentication/passwords/input.html.

You can generate the documentation by following the steps in this guide.

@lukasdo
Copy link
Author

lukasdo commented Mar 6, 2024

@marcusdacoregio, I will check the documentation generation in a bit. However the link should be correct. I used the same link that is referenced on other pages e.g.: JDBC Authentication and LDAP Authentication

You are right in earlier working versions of the documentation the link seemed to be referencing the chapter Reading the Username & Password, although the section id should be leading to 10.10. Username/Password Authentication.
Additionally the DaoAuthenticationProvider page is referencing Reading the Username & Password in the text but linking to the Username/Password Authentication page.

Hope this is understandable...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: docs An issue in Documentation or samples type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants