Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AuthorizationManager should support returning an AuthorizationResult #14843

Open
jzheaux opened this issue Apr 4, 2024 · 0 comments · May be fixed by #14846
Open

AuthorizationManager should support returning an AuthorizationResult #14843

jzheaux opened this issue Apr 4, 2024 · 0 comments · May be fixed by #14846
Labels
status: ideal-for-contribution An issue that we actively are looking for someone to help us with type: enhancement A general enhancement

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Apr 4, 2024

It would be nice for AuthoriationManager to code to the AuthorizationResult interface like so:

default AuthorizationResult authorize(Supplier<Authentication> authentication, T object) {
    return check(authentication, object);
}

This will allow implementations to code to an interface instead of a concrete class.

In turn, check should be deprecated and classes in Spring Security should implement and call authorize instead.

As when deprecating other methods, the existing tests should remain as-is to ensure that deprecated functionality continues to work.
@jzheaux jzheaux added type: enhancement A general enhancement status: ideal-for-contribution An issue that we actively are looking for someone to help us with labels Apr 4, 2024
@jzheaux jzheaux mentioned this issue Apr 4, 2024
Merged
CrazyParanoid pushed a commit to CrazyParanoid/spring-security that referenced this issue Apr 4, 2024
Add support AuthorizationResult for AuthorizationManager
7319cf2 
Added a new authorization method to AuthorizationManager that returns AuthorizationResult.

Closes spring-projectsgh-14843
@CrazyParanoid CrazyParanoid linked a pull request Apr 4, 2024 that will close this issue
Open
CrazyParanoid pushed a commit to CrazyParanoid/spring-security that referenced this issue Apr 7, 2024
Added a new authorization method to AuthorizationManager that returns…
011fea2 
… AuthorizationResult.

Closes spring-projectsgh-14843
CrazyParanoid pushed a commit to CrazyParanoid/spring-security that referenced this issue Apr 7, 2024
Added a new authorization method to AuthorizationManager that returns…
79e410c 
… AuthorizationResult.

Closes spring-projectsgh-14843
CrazyParanoid pushed a commit to CrazyParanoid/spring-security that referenced this issue Apr 7, 2024
Add support AuthorizationResult for AuthorizationManager
8b274c1 
Added a new authorization method to AuthorizationManager that returns AuthorizationResult.

Closes spring-projectsgh-14843
CrazyParanoid pushed a commit to CrazyParanoid/spring-security that referenced this issue Apr 7, 2024
Add support AuthorizationResult for AuthorizationManager
a368cd1 
Added a new authorization method to AuthorizationManager that returns AuthorizationResult.

Closes spring-projectsgh-14843
CrazyParanoid pushed a commit to CrazyParanoid/spring-security that referenced this issue Apr 7, 2024
Add support AuthorizationResult for AuthorizationManager
8ee5742 
Added a new authorization method to AuthorizationManager that returns AuthorizationResult.

Closes spring-projectsgh-14843
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: ideal-for-contribution An issue that we actively are looking for someone to help us with type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

AuthorizationManager should return AuthorizationResult CrazyParanoid/spring-security
1 participant
@jzheaux