Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish Authorization Events on WebFlux #4961

Open
joshiste opened this issue Jan 12, 2018 · 6 comments · May be fixed by #14361
Open

Publish Authorization Events on WebFlux #4961

joshiste opened this issue Jan 12, 2018 · 6 comments · May be fixed by #14361
Assignees
Labels
in: core An issue in spring-security-core type: enhancement A general enhancement

Comments

@joshiste
Copy link
Contributor

When I use the reactive WebFilter in a webflux application no AuthenticationEvents are published

@rwinch
Copy link
Member

rwinch commented Feb 9, 2018

Thanks for the report. This is currently blocked by https://jira.spring.io/browse/SPR-16481

@wyaeld
Copy link

wyaeld commented Jul 12, 2018

@rwinch it is extremely frustrating for your users that this just silently fails with no clue as to why. If you are claiming that Spring Security works for a reactive stack, please update your documentation to be extremely explicit about limitations. Auditing is considered to be a first class capability of Spring Security.

Given @jhoeller comments on https://jira.spring.io/browse/SPR-16481 can you please clarify if there is a workaround or listener class implementation that someone can do in a Reactive Stack with Spring Security. I'm currently working on an application where auditing is not optional.

@rwinch
Copy link
Member

rwinch commented Dec 3, 2020

An overdue response to @wyaeld Just because Spring Security does not publish events, doesn't mean you cannot achieve this. You are able to easily plug in custom success/failure handlers which can publish the events.

@wyaeld
Copy link

wyaeld commented Dec 4, 2020

@rwinch Appreciate the reply. Not sure if we are on the same page. The issue that was a core feature of Spring Security no longer worked, without any documentation, using your reactive implementation.

That's a pretty big issue for someone depending on the reliability of your components. As a brief glance, it doesn't appear documentation currently indicates any caveats, but since this doesn't appear to have been treated as a major problem. The handful of linked issues appears to indicate some others are still struggling with it, nearly 3 years after it first reported.

The lack of support or response on this issue forced us to reassess our framework choices, and ultimately select something with a smaller, but more reasonable to understand and maintain implementation of reactive patterns.

@rwinch
Copy link
Member

rwinch commented Dec 4, 2020

Thanks for the reply @wyaeld Sorry for the delayed response. Glad you found something that solved your problem.

@marcusdacoregio marcusdacoregio self-assigned this Oct 26, 2023
@marcusdacoregio marcusdacoregio added the type: enhancement A general enhancement label Oct 26, 2023
@marcusdacoregio marcusdacoregio changed the title when using a ReactiveAuthorizationManager no AuthenticationEvents are published Publish Authorization Events on WebFlux Dec 20, 2023
@marcusdacoregio
Copy link
Contributor

marcusdacoregio commented Dec 20, 2023

Hi all, I've reworded this ticket to be more clear that it will address the publishing of authorization events on WebFlux. We will probably follow the same approach as the servlet side bdd5f86

marcusdacoregio added a commit to marcusdacoregio/spring-security that referenced this issue Dec 21, 2023
@marcusdacoregio marcusdacoregio linked a pull request Dec 21, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core An issue in spring-security-core type: enhancement A general enhancement
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

4 participants