TODO : Reactive/Webflux support #7608

cbornet · 2018-05-11T16:06:19Z

cbornet · 2018-07-04T14:29:29Z

For information: there is currently no possibility for the entity auditing to get the current user from the ReactiveSecurityContextHolder. Hence createdBy and lastModifiedBy will have to be set explicitly. See https://jira.spring.io/browse/DATACMNS-1231

Also there is currently no support for security audits so they should be removed for now.

cbornet · 2019-01-15T23:59:34Z

Note on R2DBC : currently it's not perf enough to be considered in a real life app mainly because it doesn't support connection pooling yet. See progress on this in reactor/reactor#651

cbornet · 2019-01-23T22:55:14Z

Cool ! Micrometer just works with Webflux !

DanielFran · 2019-02-25T19:50:03Z

@cbornet Seems in springfox project integration with SB 2.1.x has been merged... and it includes migration to swagger-ui 3.

cbornet · 2019-02-25T23:12:37Z

Yes. We need the v3 of Springfox to be released. I tried to use the snapshot but had a lot of issues so I'll wait for the release. As for swagger UI, we don't use the one packaged by Springfox so we could already do the move.

cbornet · 2019-03-19T10:44:48Z

Reactor now supports a reactive pool that could be useful for R2DBC connection pooling

mp911de · 2019-05-18T10:46:01Z

R2DBC 0.8.0 M8 is out now.

cbornet · 2019-05-18T10:55:37Z

Yes. I tested it and it does improve performance a lot. Great job !

jdubois · 2019-06-18T07:41:16Z

As this is a very big one, I'm increasing the bug bounty to $500 !

cbornet · 2019-06-18T09:08:38Z

It would probably be better to open individual issues for this. But I didn't want to cripple the issue tracker. Maybe I could open a dedicated repo where we can add smaller issues with smaller bounties ?

jdubois · 2019-06-18T13:57:13Z

@cbornet you can put them on the main repo as long as we have the correct labels (maybe have a specific one for reactive), and the original plan was to have smaller $100 tickets. So if you do that we could split/move the bug bounty, but at the moment we only got this one.

cbornet · 2019-07-02T07:49:50Z

About caching, there's currently no support for @Cacheable in spring data reactive. A reactor add-on can be used to wrap the CacheManager. Note that the CacheManager being a blocking API, it kind of defeats the async non-blocking pattern. For now, the best solution seems to be to disable the cache option for reactive apps.

cbornet · 2019-07-17T15:36:27Z

There's currently no support for security nor STOMP for websockets in WebFlux. So it seems hard to do much more than a hello world right now...
The recommendation seems to be to evaluate RSocket instead which I can only agree with 😃

mraible · 2019-12-07T19:40:58Z

@cbornet I'd like to help get the Reactive support "good enough" to release as GA. Is this issue's TODO list up-to-date? If so, I can start working on OAuth support and maybe entity generation. Let me know.

cbornet · 2019-12-07T21:22:29Z

Yes the TODO is up to date. Your help on the OAuth support is very welcome if course 😀! Thanks a lot Matt !

mraible · 2019-12-08T00:50:49Z

Do you think all checkboxes are necessary for a GA release or can we hide some and add them as we implement them?

…

On Dec 7, 2019, at 14:22, Christophe Bornet ***@***.***> wrote: Yes the TODO is up to date. Your help on the OAuth support is very welcome if course 😀! Thanks a lot Matt ! — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

cbornet · 2019-12-13T20:42:12Z

Yes we can define what we want for a GA. For instance, do you think SQL support is mandatory ?

mraible · 2019-12-28T19:01:02Z

@cbornet I started working on OAuth support in #11049. I created a sample app at https://github.com/mraible/jhipster-reactive-monolith-oauth2 and a PR that makes login work.

I still need to add non-blocking support in UserService. I added // todo: comments in my PR for code that needs to be uncommented and fixed.

cbornet · 2019-12-29T06:54:51Z

Cool ! On my side, I've made progress with the r2dbc support. It's almost ready but it requires that we first upgrade to Spring 5.2.

mraible · 2019-12-30T21:21:26Z

@cbornet Do you know how to get tests to work? I'm getting the following error when I run ./mvnw test. It seems like none of the tests with @SpringBootTest are being executed.

WARNING: TestEngine with ID 'junit-vintage' failed to discover tests
java.lang.NoClassDefFoundError: junit/runner/Version
	at org.junit.vintage.engine.JUnit4VersionCheck.checkSupported(JUnit4VersionCheck.java:32)
	at org.junit.vintage.engine.VintageTestEngine.discover(VintageTestEngine.java:61)
	at org.junit.platform.launcher.core.DefaultLauncher.discoverEngineRoot(DefaultLauncher.java:177)
	at org.junit.platform.launcher.core.DefaultLauncher.discoverRoot(DefaultLauncher.java:164)
	at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:128)
	at org.apache.maven.surefire.junitplatform.JUnitPlatformProvider.invokeAllTests(JUnitPlatformProvider.java:154)
	at org.apache.maven.surefire.junitplatform.JUnitPlatformProvider.invoke(JUnitPlatformProvider.java:127)
	at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:377)
	at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:138)
	at org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:465)
	at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:451)

mraible · 2019-12-30T21:52:30Z

@cbornet Nevermind. I was able to solve this warning by changing the junit exclusion to:

<dependency>
  <groupId>org.springframework.boot</groupId>
  <artifactId>spring-boot-starter-test</artifactId>
  <scope>test</scope>
  <exclusions>
    <exclusion>
      <groupId>org.junit.vintage</groupId>
      <artifactId>junit-vintage-engine</artifactId>
    </exclusion>
  </exclusions>
</dependency>

I also realized you have to run mvn verify for the Spring Boot tests to run.

mraible · 2020-02-19T22:43:06Z

@cbornet I don't see Spring Cloud Gateway as one of the items in this issue's description. I have OAuth working with Spring Cloud Gateway in #11223. I still need to add JWT support. Not sure if Consul is necessary since we're still in Alpha mode.

mraible · 2020-02-19T23:42:51Z

FYI... it seems like a reactive monolith doesn't pass ./mvnw verify.

[ERROR] Failures:
[ERROR]   ExceptionTranslatorIT.testMethodArgumentNotValid:41 Response header 'Content-Type' expected:<application/problem+json> but was:<text/plain>

> POST /api/exception-translator-test/method-argument
> WebTestClient-Request-Id: [17]
> Content-Type: [application/json]
> Content-Length: [2]

{}

< 403 FORBIDDEN Forbidden
< Content-Type: [text/plain]
< Cache-Control: [no-cache, no-store, max-age=0, must-revalidate]
< Pragma: [no-cache]
< Expires: [0]
< X-Content-Type-Options: [nosniff]
< X-XSS-Protection: [1 ; mode=block]
< Feature-Policy: [geolocation 'none'; midi 'none'; sync-xhr 'none'; microphone 'none'; camera 'none'; magnetometer 'none'; gyroscope 'none'; speaker 'none'; fullscreen 'self'; payment 'none']
< Content-Security-Policy: [default-src 'self'; frame-src 'self' data:; script-src 'self' 'unsafe-inline' 'unsafe-eval' https://storage.googleapis.com; style-src 'self' 'unsafe-inline'; img-src 'self' data:; font-src 'self' data:]
< Referrer-Policy: [strict-origin-when-cross-origin]

CSRF Token has been associated to this client

[ERROR]   ExceptionTranslatorIT.testMethodNotSupported:96 Status expected:<405> but was:<403>

> POST /api/exception-translator-test/access-denied
> WebTestClient-Request-Id: [15]

No content

< 403 FORBIDDEN Forbidden
< Content-Type: [text/plain]
< Cache-Control: [no-cache, no-store, max-age=0, must-revalidate]
< Pragma: [no-cache]
< Expires: [0]
< X-Content-Type-Options: [nosniff]
< X-XSS-Protection: [1 ; mode=block]
< Feature-Policy: [geolocation 'none'; midi 'none'; sync-xhr 'none'; microphone 'none'; camera 'none'; magnetometer 'none'; gyroscope 'none'; speaker 'none'; fullscreen 'self'; payment 'none']
< Content-Security-Policy: [default-src 'self'; frame-src 'self' data:; script-src 'self' 'unsafe-inline' 'unsafe-eval' https://storage.googleapis.com; style-src 'self' 'unsafe-inline'; img-src 'self' data:; font-src 'self' data:]
< Referrer-Policy: [strict-origin-when-cross-origin]

CSRF Token has been associated to this client

[INFO]
[ERROR] Tests run: 33, Failures: 2, Errors: 0, Skipped: 0

Here's my .yo-rc.json:

{
  "generator-jhipster": {
    "promptValues": {
      "packageName": "com.mycompany.myapp",
      "nativeLanguage": "en"
    },
    "jhipsterVersion": "6.7.1",
    "applicationType": "monolith",
    "baseName": "mono",
    "packageName": "com.mycompany.myapp",
    "packageFolder": "com/mycompany/myapp",
    "serverPort": "8080",
    "authenticationType": "oauth2",
    "cacheProvider": "no",
    "enableHibernateCache": false,
    "websocket": false,
    "databaseType": "mongodb",
    "devDatabaseType": "mongodb",
    "prodDatabaseType": "mongodb",
    "searchEngine": false,
    "messageBroker": false,
    "serviceDiscoveryType": false,
    "buildTool": "maven",
    "enableSwaggerCodegen": false,
    "embeddableLaunchScript": false,
    "useSass": true,
    "clientPackageManager": "npm",
    "clientFramework": "angularX",
    "clientTheme": "none",
    "clientThemeVariant": "",
    "creationTimestamp": 1582154650121,
    "testFrameworks": ["protractor"],
    "jhiPrefix": "jhi",
    "entitySuffix": "",
    "dtoSuffix": "DTO",
    "otherModules": [],
    "enableTranslation": true,
    "nativeLanguage": "en",
    "languages": ["en"],
    "blueprints": [],
    "reactive": true
  }
}

mraible · 2020-02-22T16:43:14Z

@jhipster/developers Spring Cloud Gateway integration seems to be good to go! Should I merge?

I kept the Zuul code for Zuul for non-reactive apps. This means that we're just adding a feature, no breaking changes.

mraible · 2020-03-30T23:47:19Z

@cbornet Adding support for Elasticsearch seems to be the last thing to do to close this issue. Is that correct?

cbornet · 2020-03-31T04:44:55Z

Indeed ! We could even open another issue for ES and close this one.

mraible · 2020-04-01T22:50:18Z

@cbornet I created #11536 for Elasticsearch support.

cbornet · 2020-04-03T09:17:51Z

OK. I'm removing it from here since it has it's own issue.
So we just need to merge #11009 and this issue can be closed.

cbornet · 2020-04-08T13:38:41Z

All items are done so I guess we can close this big one.
Many thanks to @mraible for the work on OIDC and to @tchlyah for the couchbase support.
How do you think the bounty should be shared ?

pascalgrimaud · 2020-04-08T13:47:33Z

@cbornet : I disagree about sharing the bounty because:

it was so much work to achieve this
as you was the lead on this part, you should take the main bounty (500$) and it will be well deserved. But I'm not sure it would be enough... we can discuss if you think it's not enough :)
for other people who participated to this ticket, we can do separate bounty (100$ or more if you think it's deserved) for each part

Just tell me.
What do you think ?

deepu105 · 2020-04-08T14:29:44Z

I also agree with Pascal, we have enough money to give more bounty Thanks & Regards, Deepu

…

On Wed, Apr 8, 2020 at 3:47 PM Pascal Grimaud ***@***.***> wrote: @cbornet <https://github.com/cbornet> : I disagree about sharing the bounty because: - it was so much work to achieve this - as you was the lead on this part, you should take the main bounty (500$) and it will be well deserved. But I'm not sure it would be enough... we can discuss if you think it's not enough :) - for other people who participated to this ticket, we can do separate bounty (100$ or more if you think it's deserved) for each part Just tell me. What do you think ? — You are receiving this because you are on a team that was mentioned. Reply to this email directly, view it on GitHub <#7608 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAIOKF4MFQVFQLWPT5AI6X3RLR6APANCNFSM4E7OZQQA> .

tchlyah · 2020-04-08T14:53:03Z

Thank you @cbornet, glad to hear that I helped.

I totally agree with @pascalgrimaud, you deserve the whole bounty, and even more.

mraible · 2020-04-08T17:22:49Z

@cbornet You did as much work as I did on the OIDC integration! +1 to give you the whole bounty.

phnxfire · 2021-05-11T04:30:05Z

is there a sample code showing the reactive websocket with the features developed in this thread?

cbornet · 2021-05-26T20:40:21Z

Last time I checked, reactive WebSocket support was incomplete in Spring (no security and no STOMP). So it's currently not supported by JHipster.

deepu105 added the area: feature request 💡 label May 23, 2018

cbornet mentioned this issue Jul 3, 2018

Add Initial Reactive option support #7918

Closed

4 tasks

cbornet mentioned this issue Jul 16, 2018

Initial Reactive support #7983

Merged

4 tasks

jdubois added the $100 https://www.jhipster.tech/bug-bounties/ label Jul 23, 2018

ruddell mentioned this issue Sep 7, 2018

Add new database option for reactive microservice #8252

Closed

cbornet mentioned this issue Dec 18, 2018

Remove Couchbase option #8938

Closed

tchlyah mentioned this issue Dec 30, 2018

Add Couchbase reactive option #8997

Merged

4 tasks

cbornet mentioned this issue Feb 19, 2019

Serve static content in reactive apps #9301

Merged

4 tasks

pascalgrimaud added the theme: java label May 9, 2019

jdubois added the $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ label Jun 17, 2019

jdubois added $500 https://www.jhipster.tech/bug-bounties/ and removed $100 https://www.jhipster.tech/bug-bounties/ labels Jun 18, 2019

cbornet mentioned this issue Jul 17, 2019

Remove cache option for reactive apps #10107

Merged

4 tasks

mraible mentioned this issue Dec 28, 2019

Add OAuth 2.0 Support for Reactive Monoliths #11049

Merged

4 tasks

mraible mentioned this issue Jan 14, 2020

Add OAuth 2.0 / OIDC Auth for Reactive #11117

Merged

5 tasks

mraible mentioned this issue Feb 1, 2020

Replace Zuul with Spring Cloud Gateway for Reactive Microservices #11223

Merged

4 tasks

mraible mentioned this issue Feb 28, 2020

Update entity generator to support reactive applications #11404

Closed

4 tasks

mraible added the theme: reactive ⚛️ Spring WebFlux label Feb 28, 2020

cbornet mentioned this issue Mar 6, 2020

Add R2DBC support #11439

Merged

15 tasks

murdos mentioned this issue Mar 6, 2020

Support for reactive applications in entity subgenerator #11416

Merged

17 tasks

mraible mentioned this issue Apr 1, 2020

Update entity generator to support Elasticsearch in reactive applications #11536

Closed

1 task

cbornet closed this as completed Apr 8, 2020

pascalgrimaud added this to the 6.9.0 milestone Apr 11, 2020

MarcelRosenberger mentioned this issue Mar 15, 2021

Reactive: Integration tests with validated endpoints fail because of blocking call #14326

Closed

1 task

mraible mentioned this issue Nov 10, 2021

Offer "websocket" option, when selecting Spring Webflux #16942

Closed

1 task

TODO : Reactive/Webflux support #7608

TODO : Reactive/Webflux support #7608

Comments

cbornet commented May 11, 2018 • edited

cbornet commented Jul 4, 2018

cbornet commented Jan 15, 2019

cbornet commented Jan 23, 2019

DanielFran commented Feb 25, 2019

cbornet commented Feb 25, 2019

cbornet commented Mar 19, 2019

mp911de commented May 18, 2019

cbornet commented May 18, 2019

jdubois commented Jun 18, 2019

cbornet commented Jun 18, 2019

jdubois commented Jun 18, 2019

cbornet commented Jul 2, 2019

cbornet commented Jul 17, 2019

mraible commented Dec 7, 2019

cbornet commented Dec 7, 2019

mraible commented Dec 8, 2019 via email

cbornet commented Dec 13, 2019

mraible commented Dec 28, 2019

cbornet commented Dec 29, 2019

mraible commented Dec 30, 2019

mraible commented Dec 30, 2019

mraible commented Feb 19, 2020

mraible commented Feb 19, 2020

mraible commented Feb 22, 2020

mraible commented Mar 30, 2020 • edited

cbornet commented Mar 31, 2020

mraible commented Apr 1, 2020

cbornet commented Apr 3, 2020

cbornet commented Apr 8, 2020

pascalgrimaud commented Apr 8, 2020

deepu105 commented Apr 8, 2020 via email

tchlyah commented Apr 8, 2020

mraible commented Apr 8, 2020

phnxfire commented May 11, 2021

cbornet commented May 26, 2021

cbornet commented May 11, 2018 •

edited

mraible commented Mar 30, 2020 •

edited