Introduce HalFormsConfiguration API to sort properties. #1284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregturn
force-pushed
the
issue/HATEOAS-1114
branch
4 times, most recently
from
c30ead9
to
e12d5c2
Compare
Register various patterns of sorting based on types.
gregturn
force-pushed
the
issue/HATEOAS-1114
branch
from
e12d5c2
to
81f8501
Compare
odrotbohm
requested changes
May 11, 2020
There was a problem hiding this comment.
I'd like to avoid the exposure of the type on InputPayloadMetadata. What if we made the HalFormsConfiguration expose something that exposes a Collector per type, so that the PayloadMetadata implementation based on a type could look up the property order and sort the Stream<PropertyMetadata> returned from PayloadMetadata.stream() accordingly?
odrotbohm
force-pushed
the
main
branch
3 times, most recently
from
2e02d7a
to
856b6b9
Compare
odrotbohm
force-pushed
the
main
branch
4 times, most recently
from
5828e78
to
e643c37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.