Upgrade to federation-jvm 5.0.0 #972
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Federation JVM v5 is now using `graphql-java` v22 which caused following breaking changes in behavior
- Apollo `CacheControlInstrumentation` - was using old deprecated instrumentation methods so old version will not work with latest `spring-graphql` version
- there was a breaking change in the schema printing behavior of `@deprecated` information - previously it was always included regardless whether printed schema was filtering `@deprecated` directive definition. This is an issue for folks relying on self-managed Federation that uses `_service { sdl }` endpoint to obtain subgraph schemas as the supergraph schema would no longer include any deprecation information.
spring-projects-issues
added
the
status: waiting-for-triage
rstoyanchev
added
type: dependency-upgrade
rstoyanchev
changed the title
rstoyanchev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Federation JVM v5 is now using
graphql-javav22 which had following breaking changes in behaviorCacheControlInstrumentation- was using old deprecated instrumentation methods so old version will not work with latestspring-graphqlversion@deprecatedinformation - previously it was always included regardless whether printed schema was filtering@deprecateddirective definition. This is an issue for folks relying on self-managed Federation that uses_service { sdl }endpoint to obtain subgraph schemas as the supergraph schema would no longer include any deprecation information.