Skip to content

Commit

Permalink
Fix GraalVM reflection metadata for GraphQL client
Browse files Browse the repository at this point in the history
Prior to this commit, the embedded reachability metadata for GraalVM
would declare a reflection hint for `GraphQlWebSocketMessage` when the
RSocket or WebSocket clients are reachable.
The `CodecDelegate` relies on this message class to test codecs and
detect a JSON-capable instance. This is true for all supported
GraphQlClient implementations.

This commit revisits the embedded reachability metadata to:

* allow reflection on `GraphQlWebSocketMessage` if any client extending
  `AbstractGraphQlClientBuilder` is available
* allow reflection on `GraphQlWebSocketMessage` if a
  `GraphQlWebSocketHandler` is reachable

Fixes gh-825
  • Loading branch information
bclozel committed Oct 13, 2023
1 parent 6c15e09 commit 4912588
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"allDeclaredMethods":true,
"allDeclaredConstructors":true,
"condition": {
"typeReachable": "org.springframework.graphql.client.DefaultRSocketGraphQlClientBuilder"
"typeReachable": "org.springframework.graphql.client.AbstractGraphQlClientBuilder"
}
},
{
Expand All @@ -21,7 +21,7 @@
"allDeclaredMethods":true,
"allDeclaredConstructors":true,
"condition": {
"typeReachable": "org.springframework.graphql.client.DefaultWebSocketGraphQlClientBuilder"
"typeReachable": "org.springframework.graphql.server.webflux.GraphQlWebSocketHandler"
}
}
]

0 comments on commit 4912588

Please sign in to comment.