Fixed DataBufferLimitException in WebFlux result in 413 instead of 500 #32558
+69
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mysend12 Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@mysend12 Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
injae-kim
reviewed
Apr 1, 2024
spring-web/src/main/java/org/springframework/web/server/ServerWebInputTooLargeException.java
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
mysend12
force-pushed
the
fix/payload-too-large-status-code
branch
from
79e39c7
to
3ca0ba9
Compare
…t in 413 instead of 500
mysend12
force-pushed
the
fix/payload-too-large-status-code
branch
from
3ca0ba9
to
0b57b6c
Compare
|
@injae-kim thanks for trying to help but please refrain from providing guidelines to contributors. The first one is actually wrong, we do not need a reference to the original issue in the commit message. |
|
oh sorry, I got it! actually PR author @mysend12 is my friend and I'm helping him to contribute(by pair programming!) so provide guideline by comment :) I'll don't do this~! 🙇 thank you! |
snicoll
added
in: web
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
origin issue: #32113
hello. In WebFlux, when a DataBufferLimitException occurs because the payload is larger than the setting value (spring.codec.max-in-memory-size), a 413 Too Large Body status code should be returned, but a 500 status code was returned, so that part has been corrected.