Deprecate HttpStatus 103 CHECKPOINT in favor of new EARLY_HINTS #29816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit takes rfc8297 into account and introduces a newer code 103 HttpStatus value which uses `Early Hints` as the more correct reason phrase, deprecating the outdated `CHECKPOINT` enum value for 103. Additionally: - `HttpStatus.valueOf(103)` will return the new enum value - `HttpStatusCode#isSameCodeAs(HttpStatusCode)` is introduced to ease comparison of deprecated enums vs their newer counterparts (or any instance of a more generic `HttpStatusCode`) by comparing the integer `value()` - `HttpStatusTests` covers the new deprecation as well as the three previously deprecated codes, including a check with the above new method to ensure they have comparable integer values Supersedes and Closes spring-projectsgh-27960
simonbasle
added
in: core
|
LGTM! |
|
Good to know. I wonder if that should be a candidate for backport. I guess if we decided in favor of backport, the |
|
Sticking to 6.0 is fine I think. Backporting deprecations that late in the 5.x generation is not useful. |
|
Perfect. I've updated the I see a lot of occurrences of the annotation without any params (351 vs 182), and only 39 matches with |
simonbasle
removed
in: core
izeye
added a commit
to izeye/spring-framework
that referenced
this pull request
Jan 18, 2023
simonbasle
pushed a commit
that referenced
this pull request
Jan 18, 2023
This commit polishes the EARLY_HINTS javadocs a bit: - fix a typo - fix `since` tags to include the patch version See gh-29816
mdeinum
pushed a commit
to mdeinum/spring-framework
that referenced
this pull request
Jun 29, 2023
…ng-projects#29816) This commit takes rfc8297 into account and introduces a newer code 103 HttpStatus value which uses `Early Hints` as the more correct reason phrase, deprecating the outdated `CHECKPOINT` enum value for 103. Additionally: - `HttpStatus.valueOf(103)` will return the new enum value - `HttpStatusCode#isSameCodeAs(HttpStatusCode)` is introduced to ease comparison of deprecated enums vs their newer counterparts (or any instance of a more generic `HttpStatusCode`) by comparing the integer `value()` - `HttpStatusTests` covers the new deprecation as well as the three previously deprecated codes, including a check with the above new method to ensure they have comparable integer values Supersedes and Closes spring-projectsgh-27960
mdeinum
pushed a commit
to mdeinum/spring-framework
that referenced
this pull request
Jun 29, 2023
This commit polishes the EARLY_HINTS javadocs a bit: - fix a typo - fix `since` tags to include the patch version See spring-projectsgh-29816
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit takes rfc8297 into account and introduces a newer code 103
HttpStatus value which uses
Early Hintsas the more correct reasonphrase, deprecating the outdated
CHECKPOINTenum value for 103.Additionally:
HttpStatus.valueOf(103)will return the new enum valueHttpStatusCode#isSameCodeAs(HttpStatusCode)is introduced to easecomparison of deprecated enums vs their newer counterparts (or any
instance of a more generic
HttpStatusCode) by comparing the integervalue()HttpStatusTestscovers the new deprecation as well as the threepreviously deprecated codes, including a check with the above new
method to ensure they have comparable integer values
Supersedes and Closes gh-27960