Provide method with ContextView instead of Context in ServerWebExchangeContextFilter
#29691
+18
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singhbaljit
force-pushed
the
exchange_context_filter
branch
from
59e0bf3 to
d89616a
Compare
spring-projects-issues
added
the
status: waiting-for-triage
|
Tagging @rstoyanchev since you wrote the class originally. |
singhbaljit
changed the title
ContextView in ServerWebExchangeContextFilter
rstoyanchev
added
the
in: web
rstoyanchev
requested changes
Feb 20, 2023
There was a problem hiding this comment.
It is a reasonable and necessary change, and although it is source compatible, it is not binary compatible. We can instead introduce a new method getExchange(ContextView) and deprecate the existing one, which would provide a path to migrate.
Would you like to make this adjustment, or otherwise we can also take it from here?
rstoyanchev
added
type: enhancement
rstoyanchev
changed the title
ContextView in ServerWebExchangeContextFilterContextView instead of Context in ServerWebExchangeContextFilter
singhbaljit
force-pushed
the
exchange_context_filter
branch
from
d89616a to
ec41753
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
ContextViewinServerWebExchangeContextFilter#get.Contextis a subclass ofContextView; hence, this is a non-breaking change.Mono#transformDeferredContextualandMono#deferContextualprovideContentViewinstance. This avoids the need for a clunky cast or the unnecessary.map(Context::of).