Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "multipart/mixed" and "multipart/related" in DefaultServerWebExchange #29671

Closed
wants to merge 1 commit into from
Closed

Support "multipart/mixed" and "multipart/related" in DefaultServerWebExchange #29671

wants to merge 1 commit into from

Conversation

sephiroth-j
Copy link
Contributor

DefaultServerWebExchange ignores "multipart/mixed" and "multipart/related" and returns an empty MultiValueMap although MultipartHttpMessageReader would be able to read the request.

This completes the server-side support for "multipart/mixed" and "multipart/related" in Webflux.

Closes gh-28591

…tServerWebExchange

Signed-off-by: Ronny Perinke <23166289+sephiroth-j@users.noreply.github.com>
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Dec 9, 2022
@rstoyanchev rstoyanchev added the in: web Issues in web modules (web, webmvc, webflux, websocket) label Jan 24, 2023
@rstoyanchev rstoyanchev self-assigned this Feb 6, 2023
@rstoyanchev rstoyanchev added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Feb 6, 2023
@rstoyanchev rstoyanchev added this to the 6.0.5 milestone Feb 6, 2023
@rstoyanchev rstoyanchev changed the title [Webflux] Support "multipart/mixed" and "multipart/related" in DefaultServerWebExchange Support "multipart/mixed" and "multipart/related" in DefaultServerWebExchange Feb 6, 2023
@sephiroth-j sephiroth-j deleted the bugfix/gh-28591-fix-incomplete-multipart-support branch February 14, 2023 19:16
mdeinum pushed a commit to mdeinum/spring-framework that referenced this pull request Jun 29, 2023
mdeinum pushed a commit to mdeinum/spring-framework that referenced this pull request Jun 29, 2023
Includes small refactoring in DefaultServerWebExchange and adjustment
of initMultipartData to get involved for any "multipart/" prefixed
media type.

In addition, "multipart/related" is now in the list of media types
supported by FormHttpMessageConverter, which aligns it with
MultipartHttpMessageReader.

Closes spring-projectsgh-29671
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webflux support for decoding/parsing of "multipart/related" requests
3 participants