Make isConnected() in WebSocketConnectionManager public #28785
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@npriebe Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
spring-projects-issues
added
the
status: waiting-for-triage
rstoyanchev
added
type: enhancement
rstoyanchev
changed the title
rstoyanchev
pushed a commit
that referenced
this pull request
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my case, I was creating a ReconnectTask to connect to my WebSocket server.
Here I noticed that the method start() or startInternal() in the abstract class ConnectionManagerSupport always sets the boolean running to true. And it does this even if the connection could not be established.
This means that it is not possible to add a retry-handling if the method start() or startInternal() can successfully establish the connection to the server.
But to be able to check yourself if the connection was successfully established you need access to the method isConnected().
But if there is another way to enable retry-handling for the connection to the server, an answer would help me.