Support @Value for record injection
#28774
Conversation
wine-area
changed the title
wine-area
changed the title
spring-projects-issues
added
the
status: waiting-for-triage
rstoyanchev
added
the
in: core
rstoyanchev
changed the title
@Value for record injection
|
This aims to fix #28770. |
sbrannen
removed
the
status: waiting-for-triage
| @@ -1352,6 +1352,10 @@ protected BeanWrapper autowireConstructor( | |||
| */ | |||
| @SuppressWarnings("deprecation") // for postProcessPropertyValues | |||
| protected void populateBean(String beanName, RootBeanDefinition mbd, @Nullable BeanWrapper bw) { | |||
| // record has not set methods | |||
| if (mbd.getBeanClass().isRecord()) { | |||
There was a problem hiding this comment.
This check is insufficient, since the bean definition may not have a "bean class".
In any case, I will address this after merging this PR.
So there is no need to modify this PR.
| @@ -506,4 +516,8 @@ public TestBean testBean() throws IOException { | |||
| } | |||
| } | |||
|
|
|||
|
|
|||
| @Component | |||
| static record RecordBean(@Value("recordBeanName") String name) { | |||
There was a problem hiding this comment.
To access the recordBeanName system property, this would need to be changed to @Value("${recordBeanName}") or @Value("#{systemProperties[recordBeanName]}").
I will address this after merging this PR, so there is no need to modify this PR.
| void testValueInjectionWithRecord() { | ||
| System.setProperty("recordBeanName", "recordBean"); | ||
| GenericApplicationContext context = new AnnotationConfigApplicationContext(RecordBean.class); | ||
| context.refresh(); |
There was a problem hiding this comment.
FYI: a context cannot be refreshed multiple times.
This results in:
java.lang.IllegalStateException: GenericApplicationContext does not support multiple refresh attempts: just call 'refresh' once
I will address this after merging the PR.
Add
@Valuesupport for record injection by disablingpopulateBean()for records, since records are immutable.Addresses #28770