Correctly identify MaxUploadSizeExceededException through keywords in message from Jetty 9.4.x #28759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… message from Jetty 9.4.x
spring-projects-issues
added
the
status: waiting-for-triage
jhoeller
added
in: web
|
This has been merged into Thanks, and congratulations on submitting your first PR to the Spring Framework! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MaxUploadSizeExceededException is recognized based on the exception message containing the words "size" and "exceed". Jetty server throws a message "Request exceeds maxRequestSize...". Shouldn't such message also be treated as a MaxUploadSizeExceededException?
The proposed change addresses the issue regarding handling errors for too large file uploads when using the Jetty 9.4.x server. Now it is possible that MultipartException is thrown instead of MaxUploadSizeExceededException when the file exceeds the size limit.