Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure channelExecutors and taskScheduler in STOMP WebSocket config are qualified #28736

Closed
wants to merge 1 commit into from
Closed

Ensure channelExecutors and taskScheduler in STOMP WebSocket config are qualified #28736

wants to merge 1 commit into from

Conversation

CodeInDreams
Copy link
Contributor

@CodeInDreams CodeInDreams commented Jun 30, 2022 •
edited by rstoyanchev

There are several beans require TaskExecutor or TaskScheduler without @Qualifier, which means inject wrong executors if we declare some executor bean @Primary.

As previously discussed at #28719, I use @Qualifier instead to avoid cglib proxies.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jun 30, 2022
@sbrannen sbrannen added in: web Issues in web modules (web, webmvc, webflux, websocket) in: messaging Issues in messaging modules (jms, messaging) labels Jun 30, 2022
@sbrannen sbrannen modified the milestone: Triage Queue Jun 30, 2022
@sbrannen
Copy link
Member

Related Issues:

@rstoyanchev
Copy link
Contributor

This looks okay to me. What do you think @sdeleuze, @jhoeller?

@rstoyanchev rstoyanchev self-assigned this Jul 4, 2022
@rstoyanchev rstoyanchev modified the milestones: Triage Queue, 5.3.22 Jul 4, 2022
@rstoyanchev rstoyanchev added type: regression A bug that is also a regression and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jul 4, 2022
@rstoyanchev rstoyanchev changed the title Fix issue autowiring channelExecutors and taskScheduler in spring messaging & websocket Ensure channelExecutors and taskScheduler in STOMP WebSocket config are qualified Jul 4, 2022
@rstoyanchev
Copy link
Contributor

We'll fix this in 5.3.x. Note that a similar change was applied to the web config as well #23887.

rstoyanchev pushed a commit that referenced this pull request Jul 4, 2022
@CodeInDreams @rstoyanchev
Qualify channelExecutor and taskScheduler in WebSocket config
461ba53 
See gh-28736
rstoyanchev added a commit that referenced this pull request Jul 4, 2022
@rstoyanchev
Add missing check to avoid re-initialization
007bded 
Noticed during review of #28736 that a check protecting against
re-initialization was accidentally removed in commit
3d6e38b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rstoyanchev rstoyanchev

Labels
in: messaging Issues in messaging modules (jms, messaging) in: web Issues in web modules (web, webmvc, webflux, websocket) type: regression A bug that is also a regression
Projects
None yet
Milestone
5.3.22
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@CodeInDreams @sbrannen @rstoyanchev @spring-projects-issues