Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid Commons Logging API for using LoggingCacheErrorHandler with a custom logger #28678

Merged
merged 1 commit into from Oct 19, 2022
Merged

Avoid Commons Logging API for using LoggingCacheErrorHandler with a custom logger #28678

merged 1 commit into from Oct 19, 2022

Commits on Oct 19, 2022

  1. Avoid use of Commons Logging in LoggingCacheErrorHandler public API 

    At present, creating LoggingCacheErrorHandler with custom logger requires use of Commons Logging API, as the appropriate constructor expects org.apache.commons.logging.Log instance. As Commons Logging is rarely the logging framework of choice in applications these days, interaction with its API might not be desirable.

This commit adds LoggingCacheErrorHandler constructor that accepts logger name and thus avoids leaking out any details about the underlying logging framework.
    @vpavic
    vpavic committed Oct 19, 2022
    Copy the full SHA
    fa8e2e9 View commit details
    Browse the repository at this point in the history