Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify docs on JNDI properties in Servlet environment #28488

Conversation

arend-von-reinersdorff
Copy link
Contributor

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label May 19, 2022
@snicoll snicoll self-assigned this Jul 29, 2022
@snicoll snicoll added type: documentation A documentation task and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jul 29, 2022
@snicoll snicoll added this to the 5.3.23 milestone Jul 29, 2022
@snicoll snicoll closed this in 456c788 Jul 29, 2022
@snicoll
Copy link
Member

snicoll commented Jul 29, 2022

Thanks again @arend-von-reinersdorff

@arend-von-reinersdorff
Copy link
Contributor Author

Thanks for merging @snicoll :-)

You restored the word "including" in this phrase:

is populated with additional default property sources including servlet config, servlet context parameters, and a JndiPropertySource

I find "including" a bit misleading: It sounds like more than the 3 mentioned property sources could be added by StandardServletEnvironment. But this is not the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants