Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid multiple invocations of private lifecycle method #28113

Closed
wants to merge 1 commit into from
Closed

Avoid multiple invocations of private lifecycle method #28113

wants to merge 1 commit into from

Conversation

vikeychen
Copy link
Contributor

See gh-28083

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Feb 28, 2022
@sbrannen sbrannen added the in: core Issues in core modules (aop, beans, core, context, expression) label Feb 28, 2022
@sbrannen sbrannen linked an issue Feb 28, 2022 that may be closed by this pull request
Private init/destroy method may be invoked twice #28083
Closed
@sbrannen sbrannen marked this pull request as draft February 28, 2022 17:30
@sbrannen sbrannen self-assigned this Feb 28, 2022
@sbrannen sbrannen added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Feb 28, 2022
@sbrannen sbrannen added this to the 5.3.17 milestone Feb 28, 2022
@sbrannen sbrannen changed the title Fix multiple invocation of lifecycle private method Fix multiple invocations of private lifecycle method Feb 28, 2022
@sbrannen sbrannen mentioned this pull request Feb 28, 2022
Closed
@sbrannen sbrannen changed the title Fix multiple invocations of private lifecycle method Avoid multiple invocations of private lifecycle method Feb 28, 2022
@sbrannen sbrannen removed this from the 5.3.17 milestone Mar 1, 2022
@sbrannen sbrannen removed their assignment Mar 1, 2022
@sbrannen
Copy link
Member

sbrannen commented Mar 1, 2022

Thanks for the PR, but we have decided to approach the fix differently, and I have therefore assigned #28083 to myself.

@sbrannen sbrannen closed this Mar 1, 2022
@sbrannen
Copy link
Member

sbrannen commented Mar 1, 2022

@vikeychen, I merged your tests in af14eea, since there was no need to rewrite the work you'd already done there.

And it ended up being a bit nostalgic for me, since Spr3775InitDestroyLifecycleTests was a test class I wrote way back in 2007. 😉

Thanks!

@vikeychen
Copy link
Contributor Author

@sbrannen, wow it's been a long time! I'm glad I could be a little help. 🤓

@vikeychen vikeychen deleted the gh-28083 branch March 1, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: bug A general bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Private init/destroy method may be invoked twice
3 participants
@vikeychen @sbrannen @spring-projects-issues