Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use equals() instead of contains() in RollbackRuleAttribute #28108

Closed
wants to merge 1 commit into from
Closed

Use equals() instead of contains() in RollbackRuleAttribute #28108

wants to merge 1 commit into from

Conversation

lzj960515
Copy link

Closes gh-28098

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Feb 27, 2022
@sbrannen sbrannen marked this pull request as draft February 28, 2022 16:59
@sbrannen sbrannen self-assigned this Feb 28, 2022
@sbrannen sbrannen added the in: data Issues in data modules (jdbc, orm, oxm, tx) label Feb 28, 2022
@sbrannen
Copy link
Member

Please note that this breaks the existing RollbackRuleTests.foundEnclosedExceptionWithEnclosingException() test which means that the proposal is a breaking change.

In light of that, I am closing this PR.

@sbrannen sbrannen closed this Feb 28, 2022
@sbrannen sbrannen added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Feb 28, 2022
@sbrannen sbrannen changed the title use equals get path in RollbackRuleAttribute, Closes gh-28098 Use equals() instead of contains() in RollbackRuleAttribute Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sbrannen sbrannen

Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support type-safe transaction rollback rules
3 participants
@lzj960515 @sbrannen @spring-projects-issues