Deprecate SerializationUtils#deserialize #28075
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As based on Java's serialization mechanism, it can be the source of Remote Code Execution vulnerabilities.
Today this utility is part of the
public
API and can be naively used to convert from object to text and vice versa.However a naive use can lead to RCE vulnerability if user-input data (like files, cookies, etc.) is transfered using this utility.
I think it should be nice to at least warn the user about the use of this tool (with
@Deprecated
) and later on remove it totally from the public API as this sole use in Spring code is to clone exceptions inorg.springframework.cache.jcache.interceptor.CacheResultInterceptor
.I am not sure on how it can (or should) be handled.
Let me know if you need me to adapt the code of this PR.