Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear cache when clearing argument resolvers #27888

Closed
wants to merge 1 commit into from

Conversation

demkom58
Copy link
Contributor

@demkom58 demkom58 commented Jan 4, 2022

Getting a resolver for a parameter does not work correctly after clearing because the cache is not cleared.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jan 4, 2022
@rstoyanchev rstoyanchev self-assigned this Jan 7, 2022
@rstoyanchev rstoyanchev added in: messaging Issues in messaging modules (jms, messaging) in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jan 7, 2022
@rstoyanchev rstoyanchev added this to the 5.3.15 milestone Jan 7, 2022
@rstoyanchev
Copy link
Contributor

You're correct, although I'm curious how you came across it? The clear() method is used only in the case of the non-reactive, messaging variant, and that's from the setter for argument resolvers, which is most often called during initializations, probably before the cache fills.

@demkom58
Copy link
Contributor Author

demkom58 commented Jan 7, 2022

You're correct, although I'm curious how you came across it? The clear() method is used only in the case of the non-reactive, messaging variant, and that's from the setter for argument resolvers, which is most often called during initializations, probably before the cache fills.

Oh, I was just researching how everything works internally.

@rstoyanchev rstoyanchev changed the title Clear method parameter cache when clearing resolvers Clear cache when clearing argument resolvers Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: messaging Issues in messaging modules (jms, messaging) in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants