Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct not compiling example code in Data Access docs #27886

Closed

Conversation

jjank
Copy link
Contributor

@jjank jjank commented Jan 4, 2022

I've noticed, that there is a piece of sample code that does not compile with Spring 5.x, because the the EntityManager interface does not implement AutoCloseable until JPA 3.x (relevant commit in jpa-api)

The sample should be fine for Spring 6.x - so I'm not sure if targeting main is the correct workflow here?

Thanks for looking at this!

The EntityManager interface does not implement
AutoCloseable until v3.x of the JPA-Api

Partially reverts 189e1af
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jan 4, 2022
@sbrannen sbrannen added type: documentation A documentation task and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jan 4, 2022
@sbrannen sbrannen self-assigned this Jan 4, 2022
@sbrannen sbrannen added this to the 5.3.15 milestone Jan 4, 2022
@sbrannen
Copy link
Member

sbrannen commented Jan 4, 2022

Good catch!

And congratulations on submitting your first PR for the Spring Framework.

The sample should be fine for Spring 6.x

We're actually still using JPA 3.0 (not yet on 3.1) on main. So the example should also be changed for 6.0 for the time being.

so I'm not sure if targeting main is the correct workflow here?

I'll apply your changes to 5.3.x and forward merge to main.

@sbrannen sbrannen closed this in fdd6e50 Jan 4, 2022
@sbrannen
Copy link
Member

sbrannen commented Jan 4, 2022

This has been merged into 5.3.x and main.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants