Improve the efficiency of UrlPathHelper.getSanitizedPath() #27623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
rstoyanchev
added
in: web
sbrannen
changed the title
rstoyanchev
pushed a commit
that referenced
this pull request
Nov 9, 2021
|
The change helps more, the more duplicate slashes there are. However, for the happy scenario, which should be the most common case, it adds object allocations. I've updated the change to restore the initial check for the presence of duplicate slashes, and then continue from there if necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Tiny optimization is possible using the new method (time complexity : O(N)) instead of the old one (time complexity : O(N^2)).
Cheers,
William