Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include correct keyword in CookieAssertions failure messages #27550

Merged
merged 1 commit into from Oct 13, 2021
Merged

Include correct keyword in CookieAssertions failure messages #27550

merged 1 commit into from Oct 13, 2021

Conversation

koenpunt
Copy link
Contributor

I think the implementation of these methods was copied from the secure one, but the message wasn't updated to reflect the method name.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Oct 12, 2021
@sbrannen sbrannen self-assigned this Oct 13, 2021
@sbrannen sbrannen added in: test Issues in the test module in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Oct 13, 2021
@sbrannen sbrannen added this to the 5.3.11 milestone Oct 13, 2021
@sbrannen sbrannen changed the title Include correct keyword in assertion messages Include correct keyword in CookieAssertions failure messages Oct 13, 2021
@sbrannen sbrannen merged commit daf10d6 into spring-projects:main Oct 13, 2021
@sbrannen
Copy link
Member

Good catch.

This has been merged into 5.3.x and main.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: test Issues in the test module in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants