Use Arrays.hashCode() in ByteArrayResource.hashCode() #27544
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
jhoeller
added
in: core
sbrannen
reviewed
Oct 11, 2021
spring-core/src/main/java/org/springframework/core/io/ByteArrayResource.java
Show resolved
Hide resolved
sbrannen
added a commit
to sbrannen/spring-framework
that referenced
this pull request
Oct 11, 2021
This was referenced Oct 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation produces equal hash codes for all instances of
ByteArrayResourcewith the same length of underlying array disregarding their contents. This seems to be wrong as hash code should be calculated on the basis of the content ofbyte[].