Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support char, float, and double primitive default values in BeanUtils.instantiateClass() #27390

Closed
wants to merge 1 commit into from
Closed

Support char, float, and double primitive default values in BeanUtils.instantiateClass() #27390

wants to merge 1 commit into from

Conversation

takeaction21
Copy link
Contributor

Instantiate a class, give float and double primitive default values

@takeaction21
Update BeanUtils.java, support float and double primitive default values
19c4c94 
Instantiate a class,  give float and double primitive default values
@pivotal-cla
Copy link

@takeaction21 Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@takeaction21 Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Sep 12, 2021
@sbrannen sbrannen added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement labels Sep 14, 2021
@sbrannen sbrannen changed the title Update BeanUtils.java, support float and double primitive default values Support float and double primitive default values in BeanUtils Sep 14, 2021
@sbrannen sbrannen removed the status: waiting-for-triage An issue we've not yet triaged or decided on label Sep 14, 2021
@sbrannen sbrannen added this to the 5.3.10 milestone Sep 14, 2021
@sbrannen sbrannen self-assigned this Sep 14, 2021
@sbrannen sbrannen changed the title Support float and double primitive default values in BeanUtils Support char, float, and double primitive default values in BeanUtils Sep 14, 2021
@sbrannen
Copy link
Member

Hi @takeaction21,

Thanks for submitting your first PR to the Spring Framework! 👍

It turns out that char should also be supported. So I'll take care of that after merging your work.

@sbrannen sbrannen added the for: backport-to-5.2.x Marks an issue as a candidate for backport to 5.2.x label Sep 14, 2021
@spring-projects-issues spring-projects-issues added status: backported An issue that has been backported to maintenance branches and removed for: backport-to-5.2.x Marks an issue as a candidate for backport to 5.2.x labels Sep 14, 2021
@spring-projects-issues spring-projects-issues mentioned this pull request Sep 14, 2021
Closed
@sbrannen sbrannen changed the title Support char, float, and double primitive default values in BeanUtils Support char, float, and double primitive default values in BeanUtils.instantiateClass() Sep 14, 2021
@sbrannen
Copy link
Member

Related issues:

@sbrannen sbrannen added type: bug A general bug and removed type: enhancement A general enhancement labels Sep 14, 2021
sbrannen pushed a commit that referenced this pull request Sep 14, 2021
@takeaction21 @sbrannen
Support float and double primitive default values in BeanUtils.instan…
92cd680 
…tiateClass()

See gh-27390
sbrannen added a commit that referenced this pull request Sep 14, 2021
@sbrannen
Introduce test for gh-27390
5cc0984
@sbrannen sbrannen closed this in f07e6a1 Sep 14, 2021
sbrannen pushed a commit to sbrannen/spring-framework that referenced this pull request Sep 14, 2021
@takeaction21 @sbrannen
Support float and double primitive default values in BeanUtils.instan…
e1ba3e7 
…tiateClass()

See spring-projectsgh-27390
sbrannen added a commit to sbrannen/spring-framework that referenced this pull request Sep 14, 2021
@sbrannen
Introduce test for spring-projectsgh-27390
4d1cdf6
sbrannen added a commit that referenced this pull request Sep 14, 2021
@sbrannen
Support char primitive default values in BeanUtils.instantiateClass()
1ad5b4f 
Closes gh-27390
@sbrannen
Copy link
Member

This has been merged into main in 92cd680, revised in 5cc0984 and f07e6a1, and backported to 5.2.17 (see #27401).

Thanks

@sync-by-unito sync-by-unito bot mentioned this pull request Sep 15, 2021
Closed
lxbzmy pushed a commit to lxbzmy/spring-framework that referenced this pull request Mar 26, 2022
@takeaction21 @lxbzmy
Support float and double primitive default values in BeanUtils.instan…
a4aaf90 
…tiateClass()

See spring-projectsgh-27390
lxbzmy pushed a commit to lxbzmy/spring-framework that referenced this pull request Mar 26, 2022
@sbrannen @lxbzmy
Introduce test for spring-projectsgh-27390
f4cf650
lxbzmy pushed a commit to lxbzmy/spring-framework that referenced this pull request Mar 26, 2022
@sbrannen @lxbzmy
Support char primitive default values in BeanUtils.instantiateClass()
b6f6529 
Closes spring-projectsgh-27390
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sbrannen sbrannen

Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: backported An issue that has been backported to maintenance branches type: bug A general bug
Projects
None yet
Milestone
5.3.10
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@takeaction21 @pivotal-cla @sbrannen @spring-projects-issues